[ 
https://issues.apache.org/jira/browse/KUDU-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438244#comment-15438244
 ] 

Adar Dembo commented on KUDU-1534:
----------------------------------

Thanks for doing all of that testing. Unfortunately, I don't think it covers 
the scenarios at work here.

Let's enumerate the changes:
* TSRegistrationPB -> ServerRegistrationPB in TSHeartbeatRequestPB. To test 
this, you need to run a master/tserver combination of mixed versions. For 
example, a cluster where the master is built from trunk and the tserver is 
running on 0.10.0 bits.
* TSRegistrationPB -> ServerRegistrationPB in ListTabletServersResponsePB. To 
test this, you need to run a master/client combination of mixed versions.

As far as I can tell, your testing didn't mix versions. Moreover, the client 
you did use (ts-cli) doesn't issue a ListTabletServers request.

How about this test plan:
# Start a master and tserver using bits from 0.10.0. Create a non-replicated 
table. Write some data into it. Stop the master but keep the tserver running.
# Restart the master using bits from trunk.
# Verify that the master is receiving the tserver's heartbeats. You can use the 
master's web UI for this, or you can look at the tserver/master logs for 
heartbeating errors.
# Run kudu-ksck from 0.10.0. One of the things it'll do is issue a 
ListTabletServers call to the master.


> expose software version in ListMaster RPC response
> --------------------------------------------------
>
>                 Key: KUDU-1534
>                 URL: https://issues.apache.org/jira/browse/KUDU-1534
>             Project: Kudu
>          Issue Type: Improvement
>            Reporter: Dan Burkert
>            Assignee: Dinesh Bhat
>            Priority: Minor
>              Labels: newbie
>         Attachments: cluster-downgrade.log, cluster-upgrade.log
>
>
> KUDU-1490 exposed the software version of tablet servers in the 
> GetTabletServers RPC response, but an equivalent doesn't exist for 
> ListMasters response.  This will become more important as multi-master setups 
> get more common.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to