[
https://issues.apache.org/jira/browse/KUDU-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492170#comment-16492170
]
Ferenc Szabo edited comment on KUDU-2438 at 5/29/18 2:40 PM:
-------------------------------------------------------------
CR is here:
https://gerrit.cloudera.org/#/c/10524/
The gradle and maven build produced different classes because the maven
compiler plugin was not using the error prone compiler configured in the gradle
build.
I have added that to the config and created a script that compares the jars
from the two build.
https://gist.github.com/szaboferee/c651604912d076ad4cf425bd8f4b6914#file-jardiff-sh
Just build the project with gradle and maven as well, then run the script to
see if there are any differences. I have ignored the META-INF differences
because the two build is expected to be different at the metadata level.
Before the <relocations> tag, the jardiff showed the original guava class
references, after adding it, they were the same.
was (Author: fszabo):
CR is here:
https://gerrit.cloudera.org/#/c/10524/
The gradle and maven build produced different classes because the maven
compiler plugin was not using the error prone compiler configured in the gradle
build.
I have added that to the config and created a script that compares the jars
from the two build.
https://gist.github.com/szaboferee/c651604912d076ad4cf425bd8f4b6914#file-jardiff-sh
Just build the project with gradle and maven as well, then run the script to
see if there are any differences. I have ignored the META-INF differences
because the two build is expected to be different at the metadata level.
Before the <relocations> tag, the jardiff showed the original gradle class
references, after adding it, they were the same.
> Class relocation in the maven build should be the same as in the gradle build
> -----------------------------------------------------------------------------
>
> Key: KUDU-2438
> URL: https://issues.apache.org/jira/browse/KUDU-2438
> Project: Kudu
> Issue Type: Bug
> Reporter: Ferenc Szabo
> Assignee: Ferenc Szabo
> Priority: Major
>
> The shaded jars from maven are referencing the original classes from guava
> for example.
> the maven-shade-plugin should be configured to relocate them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
