[ 
https://issues.apache.org/jira/browse/KUDU-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607318#comment-16607318
 ] 

Grant Henke commented on KUDU-2409:
-----------------------------------

I don't have a preference. Whatever you would like to do is great. 

I think fixing checkstyle issues may naturally resolve other issues. So that 
could be a good place. 

Alternatively/additionally, we could look at using an auto formatter for Java 
code like we do for Scala. There is some discussion on the scalafmt patch about 
using the Gradle spotless plugin which could enable this: 

https://gerrit.cloudera.org/#/c/11030/2//COMMIT_MSG@9 

> Fix Java style checkers and linters
> -----------------------------------
>
>                 Key: KUDU-2409
>                 URL: https://issues.apache.org/jira/browse/KUDU-2409
>             Project: Kudu
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>            Priority: Major
>
> Currently our Java build supports code quality checks like checkstyle but 
> does not enable them to break the build because we have too many existing 
> issues.
> This Jira is to track:
>  * Fixing checkstyle issues
>  * Fixing findbugs issues (change to SpotBugs?)
>  * Fixing PMD issues
>  * Fixing Javadoc linter issues
>  * Fixing un-annotated deprecated and unsafe usages
>  * Adding flags to detect/prevent the issues in the future
> Note: We may also want to prevent the use of some packages/classes. For 
> example we could prevent the use of 
> "com.google.common.annotations.VisibleForTesting" given that Yetus is our 
> audience interface annotation library of choice.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to