[
https://issues.apache.org/jira/browse/KUDU-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874123#comment-16874123
]
Xu Yao commented on KUDU-2876:
------------------------------
I think we could add a Tablet::GetComponentsOrNull function.
Tablet::GetComponents to verify that the output parameter is not null,
Tablet::GetComponentsOrNull does not verify. I will do this work. :)
> Audit the semantics and the usage of Tabet::GetComponents() in tablet.cc
> ------------------------------------------------------------------------
>
> Key: KUDU-2876
> URL: https://issues.apache.org/jira/browse/KUDU-2876
> Project: Kudu
> Issue Type: Task
> Components: tserver
> Affects Versions: 1.10.0
> Reporter: Alexey Serbin
> Assignee: Xu Yao
> Priority: Minor
>
> As of now, {{Tablet::GetComponents()}} is used in multiple places in the
> implementation of the {{kudu::tablet::Tablet}} class. In some cases the code
> verifies that the output parameter is null, in others not. And it seems in
> some cases returning null would be an error, in some cases not. It would be
> nice to do a bit of audit in that area to make sure there will be no
> unexpected SIGSEGV crashes in some corner cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
