[ 
https://issues.apache.org/jira/browse/KUDU-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927789#comment-16927789
 ] 

Adar Dembo commented on KUDU-2934:
----------------------------------

bq. For this kind of metric, maybe a percentile type metric is more reasonable?

Percentile of what exactly? Could you be more specific?

Sounds like you want more control over how metrics are merged. Your initial 
patch treated merging as a SUM of two metrics, but you're right that for some 
metrics, AVG (or perhaps some other operator) is more appropriate. Seems 
reasonable to allow that sort of thing to be defined on a per-metric basis.

> Bad merge behavior for some metrics
> -----------------------------------
>
>                 Key: KUDU-2934
>                 URL: https://issues.apache.org/jira/browse/KUDU-2934
>             Project: Kudu
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 1.11.0
>            Reporter: Yingchun Lai
>            Priority: Minor
>
> We added a feature to merge metrics by commit 
> fe6e5cc0c9c1573de174d1ce7838b449373ae36e ([metrics] Merge metrics by the same 
> attribute), for AtomicGauge type metrics, we sum up of merged metrics, this 
> work for almost all of metrics in Kudu.
> But I found a metric that could not be merged like this simply, i.e. 
> "average_diskrowset_height", because it's a "average" value.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to