[ https://issues.apache.org/jira/browse/KUDU-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995999#comment-16995999 ]
Attila Bukor commented on KUDU-1938: ------------------------------------ These commits also belong to KUDU-1938, but have been committed before the commit bot was set up. https://gitbox.apache.org/repos/asf?p=kudu.git&h=768b688 commit 768b6885485dcb74f2731ba59fdebf2e28d0a3a3 Author: Attila Bukor <abu...@apache.org> AuthorDate: Tue Oct 1 18:01:23 2019 +0200 Commit: Attila Bukor <abu...@apache.org> CommitDate: Wed Oct 23 08:45:32 2019 +0000 KUDU-1938 Add range partition support pt 6 Change-Id: Ib82985f09fef8d3372f40412156cd7a8ce69d61c Reviewed-on: http://gerrit.cloudera.org:8080/14333 Reviewed-by: Grant Henke <granthe...@apache.org> Tested-by: Kudu Jenkins https://gitbox.apache.org/repos/asf?p=kudu.git&h=85fe726 commit 85fe726794c1f0f4cc4a3add4afbdf14fc3544ce Author: Attila Bukor <abu...@apache.org> AuthorDate: Wed Sep 25 17:13:36 2019 +0200 Commit: Attila Bukor <abu...@apache.org> CommitDate: Wed Oct 23 08:45:22 2019 +0000 KUDU-1938 [hms] Add HMS support for VARCHAR pt 5 Change-Id: If929bd14eb8d1b2e54ea7892c2f85a3b1305c05d Reviewed-on: http://gerrit.cloudera.org:8080/14303 Reviewed-by: Grant Henke <granthe...@apache.org> Tested-by: Kudu Jenkins https://gitbox.apache.org/repos/asf?p=kudu.git&h=e2b2fb2 commit e2b2fb25335fe517e46cdd61924698b36e9cc652 Author: Attila Bukor <abu...@apache.org> AuthorDate: Tue Sep 24 18:51:52 2019 +0200 Commit: Attila Bukor <abu...@apache.org> CommitDate: Wed Oct 23 08:45:15 2019 +0000 KUDU-1938 [java] Add support for VARCHAR pt 4 Adds support for VARCHAR type to the Java and Spark clients. The kudu-client only changes would break tests in kudu-spark and kudu-backup so this patch also incorporates changes in these subprojects. Change-Id: I03edf5e65409e895512d5cd81a607180632e8995 Reviewed-on: http://gerrit.cloudera.org:8080/14050 Reviewed-by: Grant Henke <granthe...@apache.org> Tested-by: Kudu Jenkins https://gitbox.apache.org/repos/asf?p=kudu.git&h=9067963 commit 9067963c94a5263e5c1cb0c87d839ac7b6f0f449 Author: Attila Bukor <abu...@apache.org> AuthorDate: Tue Sep 24 15:36:08 2019 +0200 Commit: Attila Bukor <abu...@apache.org> CommitDate: Wed Oct 23 08:45:05 2019 +0000 KUDU-1938 Add non-copy VARCHAR setters pt 3 Apache Impala uses KuduPartialRow API to determine which partition a row will be inserted to distribute the data between executors optimally. For this purpose the copy is unnecessary and it should be fast. This commit adds NoCopyUnsafe variants for this purpose which expect the data to already be truncated (which it is in Impala's case) and only check that the value's length is lower than the highest possible upper bound: val.size() < max_length*4 bytes (the maximum size of an UTF8 character) to avoid having to count each character manually. Change-Id: I1f2aba098d649eb94e0314f6606cc33600e8d766 Reviewed-on: http://gerrit.cloudera.org:8080/13928 Reviewed-by: Adar Dembo <a...@cloudera.com> Reviewed-by: Grant Henke <granthe...@apache.org> Tested-by: Kudu Jenkins https://gitbox.apache.org/repos/asf?p=kudu.git&h=4343fb7 commit 4343fb746766b166f5532d36afbe903fdf092b95 Author: Attila Bukor <abu...@apache.org> AuthorDate: Tue Sep 24 15:19:21 2019 +0200 Commit: Attila Bukor <abu...@apache.org> CommitDate: Tue Oct 22 21:23:48 2019 +0000 KUDU-1938 Add C++ client support for VARCHAR pt 2 Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Reviewed-on: http://gerrit.cloudera.org:8080/13869 Reviewed-by: Grant Henke <granthe...@apache.org> Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins https://gitbox.apache.org/repos/asf?p=kudu.git&h=caa8d6d commit caa8d6d2fc9988dbd8c6331b2ab14f1a5cf63e56 Author: Attila Bukor <abu...@apache.org> AuthorDate: Tue Sep 24 14:00:55 2019 +0200 Commit: Attila Bukor <abu...@apache.org> CommitDate: Tue Oct 22 21:23:40 2019 +0000 KUDU-1938 Add support for VARCHAR pt 1 Introduces the VARCHAR data type to the server. Follow up commits will add integration to the clients. The VARCHAR type is parameterized with a length column type attribute similar to DECIMAL's scale and precision. Internally it's stored as BINARY. The maximum length for VARCHAR is 65,535 characters. If a value longer than the "n" is submitted for a VARCHAR(n) column the value is truncated to "n" characters before persisting the data on the server side. The maximum length was chosen for compatibility reasons. Apache Impala has a maximum length of 65,535 *bytes* for VARCHAR and major RDBMSs I checked also have a similar limits either in characters or bytes, mostly configurable. Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 Reviewed-on: http://gerrit.cloudera.org:8080/13760 Reviewed-by: Alexey Serbin <aser...@cloudera.com> Tested-by: Kudu Jenkins Reviewed-by: Grant Henke <granthe...@apache.org> Reviewed-by: Adar Dembo <a...@cloudera.com> > Support for VARCHAR type > ------------------------ > > Key: KUDU-1938 > URL: https://issues.apache.org/jira/browse/KUDU-1938 > Project: Kudu > Issue Type: New Feature > Components: client, tablet > Reporter: Farzana Kader > Assignee: Attila Bukor > Priority: Major > Labels: limitations, roadmap-candidate > Fix For: 1.12.0 > > > VARCHAR is currently not supported by Kudu. This is functionality that > currently exists in Impala. Some client applications convert STRING to 32K > bytes which causes performance issues so they need the VARCHAR support in > order to integrate well with Kudu. -- This message was sent by Atlassian Jira (v8.3.4#803005)