[ 
https://issues.apache.org/jira/browse/KUDU-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001173#comment-17001173
 ] 

ASF subversion and git services commented on KUDU-3031:
-------------------------------------------------------

Commit beca18bb2f4b371cf08447e1dfbcea00821fa386 in kudu's branch 
refs/heads/master from liusheng
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=beca18b ]

KUDU-3031. Fix wrong including path in gutil/atomicops.h

Change-Id: Iab0db0660e6344ef5d07c72f0839bab3e291cd7f
Reviewed-on: http://gerrit.cloudera.org:8080/14936
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <[email protected]>


> wrong including path in gutil/atomicos.h
> ----------------------------------------
>
>                 Key: KUDU-3031
>                 URL: https://issues.apache.org/jira/browse/KUDU-3031
>             Project: Kudu
>          Issue Type: Bug
>            Reporter: liusheng
>            Priority: Major
>
> In gutil/atomicos.h, there are paltform specific macros definitions as 
> following
> {code:java}
> #if defined(THREAD_SANITIZER)
> #include "kudu/gutil/atomicops-internals-tsan.h" // IWYU pragma: export
> #elif defined(__APPLE__)
> #include "kudu/gutil/atomicops-internals-macosx.h" // IWYU pragma: export
> #elif defined(__GNUC__) && defined(ARMV6)
> #include "kudu/gutil/atomicops-internals-arm-v6plus.h" // IWYU pragma: export
> #elif defined(ARMV3)
> #include "kudu/gutil/atomicops-internals-arm-generic.h" // IWYU pragma: export
> #elif defined(__GNUC__) && (defined(__i386) || defined(__x86_64__))
> #include "kudu/gutil/atomicops-internals-x86.h" // IWYU pragma: export
> #elif defined(__GNUC__) && defined(ARCH_POWERPC64)
> #include "kudu/gutil/atomicops-internals-powerpc.h" // IWYU pragma: export
> #elif defined(OS_WINDOWS)
> #include "kudu/gutil/tomicops-internals-windows.h" // IWYU pragma: export
> #else
> #error You need to implement atomic operations for this architecture
> #endif
> {code}
> but the atomicops-internals-arm-v6plus.h, atomicops-internals-arm-generic.h 
> and tomicops-internals-windows.h are under gutil/auxiliary/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to