[ 
https://issues.apache.org/jira/browse/KUDU-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062705#comment-17062705
 ] 

ASF subversion and git services commented on KUDU-3067:
-------------------------------------------------------

Commit a80d7472110ae2349a82c2150aad61079969b337 in kudu's branch 
refs/heads/master from Alexey Serbin
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=a80d747 ]

[util] KUDU-3067 add OpenStack metadata detector

This patch adds OpenStack metadata detector that works with OpenStack
Nova metadata server (see [1] for details).  In addition, this patch
fixes the existing AWS detector to tell apart a true EC2 instance
from a masquerading OpenStack one [2].

I couldn't get access to an OpenStack instance, but I asked the reporter
of KUDU-3067 to test how it works and report back.

1. https://docs.openstack.org/nova/latest/user/metadata.html#metadata-service
2. https://docs.openstack.org/nova/latest/user/metadata.html#metadata-ec2-format

Change-Id: I84cc6d155ab1fbd7b401f5349d292f46fcac3a34
Reviewed-on: http://gerrit.cloudera.org:8080/15488
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <a...@cloudera.com>
Reviewed-by: liusheng <liusheng2...@gmail.com>


> Inexplict cloud detection for AWS and OpenStack based cloud by querying 
> metadata
> --------------------------------------------------------------------------------
>
>                 Key: KUDU-3067
>                 URL: https://issues.apache.org/jira/browse/KUDU-3067
>             Project: Kudu
>          Issue Type: Bug
>            Reporter: liusheng
>            Assignee: Alexey Serbin
>            Priority: Major
>
> The cloud detector is used to check the cloud provider of the instance, see 
> [here|#L59-L93]],  For AWS cloud it using the URL 
> [http://169.254.169.254/latest/meta-data/instance-id|http://169.254.169.254/latest/meta-data/instance-id*]
>  to check the specific metadata to determine it is AWS instance. This is OK, 
> but for OpenStack based cloud, the metadata is same with AWS, so this URL can 
> also be accessed. So this cannot distinct the AWS and other OpenStack based 
> clouds. This caused an issue when run 
> "HybridClockTest.TimeSourceAutoSelection" test case, this test will use the 
> above URL to detect the Cloud of instance current running on and then try to 
> call the NTP service, for AWS, the dedicated NTP service is 
> "169.254.169.123", but for OpenStack based cloud, there isn't such a 
> dedicated NTP service. So this test case will fail if I run on a instance of 
> OpenStack based cloud because the cloud detector suppose it is AWS instance 
> and try to access "169.254.169.123".
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to