[
https://issues.apache.org/jira/browse/KUDU-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134001#comment-17134001
]
ASF subversion and git services commented on KUDU-3145:
-------------------------------------------------------
Commit 3d50fb1191cfb6c50640992efb23ed1202ce5441 in kudu's branch
refs/heads/master from huangtianhua
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=3d50fb1 ]
KUDU-3145 Skip old gold in our list of candidate linkers
Older versions of the gold linker are vulnerable to a bug which
prevents weak symbols from being overridden properly. This leads to
omitting of Kudu's tcmalloc dependency if using dynamic linking,
and some related tests failed in DEBUG build mode.
This change moves KUDU_LINK setting before choosing the linker
to make sure to skip old gold if using dynamic linking.
Change-Id: I2d7dbd6a828f14a6790be657b0f497a4887a6f82
Reviewed-on: http://gerrit.cloudera.org:8080/16049
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
> KUDU_LINK should be set before function APPEND_LINKER_FLAGS is called
> ---------------------------------------------------------------------
>
> Key: KUDU-3145
> URL: https://issues.apache.org/jira/browse/KUDU-3145
> Project: Kudu
> Issue Type: Sub-task
> Reporter: zhaorenhai
> Assignee: huangtianhua
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> KUDU_LINK should be set before function APPEND_LINKER_FLAGS is called
>
> Because in function APPEND_LINKER_FLAGS , there are following logic:
> {code:java}
> if ("${LINKER_FAMILY}" STREQUAL "gold")
> if("${LINKER_VERSION}" VERSION_LESS "1.12" AND
> "${KUDU_LINK}" STREQUAL "d")
> message(WARNING "Skipping gold <1.12 with dynamic linking.")
> continue()
> endif()
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
