[
https://issues.apache.org/jira/browse/KUDU-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691862#comment-17691862
]
ASF subversion and git services commented on KUDU-3451:
-------------------------------------------------------
Commit 9fa18d2bd53b4b54439b7967a3b6311c3f65fe81 in kudu's branch
refs/heads/master from Marton Greber
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=9fa18d2bd ]
KUDU-3451 fix memory leak in scan_token-test
This patch adds ElementDeleters to the test "TestScanTokensWithQueryId"
to fix the scan token leaks.
Running the test “TestScanTokensWithQueryId” 1024 times:
- without this patch all of them failed,
- with this patch, none of them failed, all were succesful.
Change-Id: Ic9f47dc0842f415ab1725a8080d59595896dc57e
Reviewed-on: http://gerrit.cloudera.org:8080/19526
Reviewed-by: Attila Bukor <[email protected]>
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <[email protected]>
Reviewed-by: Yifan Zhang <[email protected]>
> Memory leak in scan-token-test
> ------------------------------
>
> Key: KUDU-3451
> URL: https://issues.apache.org/jira/browse/KUDU-3451
> Project: Kudu
> Issue Type: Bug
> Components: test
> Reporter: YifanZhang
> Assignee: Marton Greber
> Priority: Major
> Attachments: scan_token-test.txt.gz
>
>
> We found test failures in scan-token-test sometimes recently. I've attached
> the full test log.
> The ASAN test output is:
> {code:java}
> Direct leak of 16 byte(s) in 2 object(s) allocated from:
> #0 0x493e48 in operator new(unsigned long)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-11.0.0.src/projects/compiler-rt/lib/asan/asan_new_delete.cpp:99
> #1 0x7fcabfc846dd in
> kudu::client::KuduScanTokenBuilder::Data::Build(std::vector<kudu::client::KuduScanToken*,
> std::allocator<kudu::client::KuduScanToken*> >*)
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/scan_token-internal.cc:616:49
> #2 0x7fcabfaf38aa in
> kudu::client::KuduScanTokenBuilder::Build(std::vector<kudu::client::KuduScanToken*,
> std::allocator<kudu::client::KuduScanToken*> >*)
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/client.cc:2337:17
> #3 0x4afd01 in
> kudu::client::ScanTokenTest_TestScanTokensWithQueryId_Test::TestBody()
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/scan_token-test.cc:748:5
> #4 0x7fcab3bb10ec in void
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2599
> #5 0x7fcab3bb10ec in void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2635
> #6 0x7fcab3ba5bda in testing::Test::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2674
> #7 0x7fcab3ba5d9c in testing::TestInfo::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2853
> #8 0x7fcab3ba6376 in testing::TestSuite::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:3012
> #9 0x7fcab3ba677b in testing::internal::UnitTestImpl::RunAllTests()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:5870
> #10 0x7fcab3bb160c in bool
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2599
> #11 0x7fcab3bb160c in bool
> testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2635
> #12 0x7fcab3ba5e62 in testing::UnitTest::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:5444
> #13 0x7fcac70caf91 in RUN_ALL_TESTS()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/installed/uninstrumented/include/gtest/gtest.h:2293:73
> #14 0x7fcac70c94a8 in main
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/test_main.cc:109:10
> #15 0x7fcaaf308bf6 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)Direct leak of 16 byte(s) in 2
> object(s) allocated from:
> #0 0x493e48 in operator new(unsigned long)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/llvm-11.0.0.src/projects/compiler-rt/lib/asan/asan_new_delete.cpp:99
> #1 0x7fcabfc846dd in
> kudu::client::KuduScanTokenBuilder::Data::Build(std::vector<kudu::client::KuduScanToken*,
> std::allocator<kudu::client::KuduScanToken*> >*)
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/scan_token-internal.cc:616:49
> #2 0x7fcabfaf38aa in
> kudu::client::KuduScanTokenBuilder::Build(std::vector<kudu::client::KuduScanToken*,
> std::allocator<kudu::client::KuduScanToken*> >*)
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/client.cc:2337:17
> #3 0x4ae967 in
> kudu::client::ScanTokenTest_TestScanTokensWithQueryId_Test::TestBody()
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/scan_token-test.cc:724:5
> #4 0x7fcab3bb10ec in void
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2599
> #5 0x7fcab3bb10ec in void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2635
> #6 0x7fcab3ba5bda in testing::Test::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2674
> #7 0x7fcab3ba5d9c in testing::TestInfo::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2853
> #8 0x7fcab3ba6376 in testing::TestSuite::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:3012
> #9 0x7fcab3ba677b in testing::internal::UnitTestImpl::RunAllTests()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:5870
> #10 0x7fcab3bb160c in bool
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2599
> #11 0x7fcab3bb160c in bool
> testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*)
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:2635
> #12 0x7fcab3ba5e62 in testing::UnitTest::Run()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/src/googletest-release-1.12.1/googletest/src/gtest.cc:5444
> #13 0x7fcac70caf91 in RUN_ALL_TESTS()
> /home/jenkins-slave/workspace/kudu-master/2/thirdparty/installed/uninstrumented/include/gtest/gtest.h:2293:73
> #14 0x7fcac70c94a8 in main
> /home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/test_main.cc:109:10
> #15 0x7fcaaf308bf6 in __libc_start_main
> (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
