[
https://issues.apache.org/jira/browse/KUDU-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815077#comment-17815077
]
ASF subversion and git services commented on KUDU-3549:
-------------------------------------------------------
Commit b18f36ccf823da552ee9272fd36852fb7d74498b in kudu's branch
refs/heads/branch-1.17.x from Alexey Serbin
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=b18f36ccf ]
[test] a small clean-up on StringGaugePrometheusTest
I took a quick look at KUDU-3549, and a natural first step was to check
whether we have a proper test coverage for handling StringGauge in when
dumping metrics in Prometheus format. The result was this patch, adding
a couple new sub-scenarios into MetricsTest.StringGaugePrometheusTest.
While this didn't lead to discovering the root case of the reported
issue, the new sub-scenarios are still useful since they provide extra
coverage for the related functionality. I also took the liberty of
cleaning up the code a bit.
Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087
Reviewed-on: http://gerrit.cloudera.org:8080/20984
Reviewed-by: Yingchun Lai <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
(cherry picked from commit ce8ef84d9cf1c4aca8edd07920dfef274edb8df4)
Reviewed-on: http://gerrit.cloudera.org:8080/21006
> String gauge exposed in prometheus format
> -----------------------------------------
>
> Key: KUDU-3549
> URL: https://issues.apache.org/jira/browse/KUDU-3549
> Project: Kudu
> Issue Type: Bug
> Components: metrics
> Affects Versions: 1.17.0
> Reporter: YUBI LEE
> Assignee: Alexey Serbin
> Priority: Major
>
> According to KUDU-3375, "Kudu now exposes all its metrics except for string
> gauges in Prometheus format via the embedded webserver's
> `/metrics_prometheus` endpoint".
>
> *
> [https://github.com/apache/kudu/blob/89e2715faf96afe0b67482166fda9c8699e8052f/docs/prior_release_notes.adoc?plain=1#L143-L145]
> * https://issues.apache.org/jira/browse/KUDU-3375
>
> However, with this commit
> ([https://github.com/apache/kudu/commit/e65ea38a4860c007d93ada9c991bccec903a80b1)]
> , string gauge related to clock_ntp_status is exposed.
>
> {code:java}
> # HELP kudu_master_clock_ntp_status Output of ntp_adjtime()/ntp_gettime()
> kernel API call
> # TYPE kudu_master_clock_ntp_status gauge
> kudu_master_clock_ntp_status{unit_type="state"} now:1706665936956760
> maxerror:70013 status:ok {code}
> It prevents prometheus operators from collecting prometheus metrics for kudu.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
