[
https://issues.apache.org/jira/browse/KUDU-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011338#comment-18011338
]
ASF subversion and git services commented on KUDU-1457:
-------------------------------------------------------
Commit f8ccb5656925115de0aed4c80f524f3d9d7c02a0 in kudu's branch
refs/heads/master from Ashwani Raina
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=f8ccb5656 ]
KUDU-1457 [2/n] add IPv6 support to squeasel function
As part of adding IPv6 support, this patch enables squeasel to
return a generic address structure for bound addresses instead of IPv4
address structure in all cases. Caller can typecast returned address
structure to either IPv4 (i.e. sockaddr_in) or IPv6 (i.e. sockaddr_in6)
depending on the address family.
The patch fixes the following issues:
1. Check the config for null before converting to integer using atoi
to avoid crash due to SIGSEGV. This is possible when using a fake
context that doesn’t bear valid config for request timeout.
2. Fix test_parse_port_string test to correct the expectation that
wrongly considers 0 as invalid port. 0 has special meaning i.e.
'any port'.
3. Add 4 new test cases for different scenarios applicable to
se_get_bound_addresses changes.
4. Add runtime library for successful compilation of unit_test.
Without these libraries, unit_test binary creation fails due to
undefined reference errors during linking.
5. Add negative test scenarios for IPv6 to test_parse_port_string.
6. Remove wrong test case from test_should_keep_alive. The test case
incorrectly expects HTTP/1.1 Connection keep-alive request to fail
'keep-alive' check. The expectation to fail the check applies to
previous case i.e. HTTP/1.1 with 'Connection close' request.
7. Remove setting of conn.status_code as it serves no purpose.
Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9
Reviewed-on: http://gerrit.cloudera.org:8080/23016
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
> IPv6 support in kudu
> --------------------
>
> Key: KUDU-1457
> URL: https://issues.apache.org/jira/browse/KUDU-1457
> Project: Kudu
> Issue Type: New Feature
> Components: rpc, util
> Reporter: Manukranth Kolloju
> Assignee: Ritwik Yadav
> Priority: Major
> Labels: roadmap-candidate
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> Worked on a patch to make kudu work in an IPv6 setup. It needed some breaking
> changes. Before spending more time making it backwards compatible, wanted to
> get some feedback about whether something like this is interesting to people
> here: https://github.com/cloudera/kudu/pull/6.
> The tests etc. all pass, except for client_sample_test which relies on the
> 127.x.x.x space as opposed to ::1 in ipv6.
> If we agree upon a uniform way to configure IPv6, I can get a patch up for
> review.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
