[
https://issues.apache.org/jira/browse/KUDU-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093529#comment-18093529
]
Jason Romero commented on KUDU-3775:
------------------------------------
Hello there,
I would like to start working on this one as well, if it's ok for a newbie to
take.
cc: [~mgreber]
> BuildPrometheusLabels DCHECK restricts new Prometheus label format to known
> entity types
> ----------------------------------------------------------------------------------------
>
> Key: KUDU-3775
> URL: https://issues.apache.org/jira/browse/KUDU-3775
> Project: Kudu
> Issue Type: Improvement
> Reporter: Marton Greber
> Priority: Minor
>
> BuildPrometheusLabels() in prometheus_writer.cc contains a DCHECK that
> hard-codes the set of valid entity types to "server", "table", and "tablet":
>
> DCHECK(entity_type == "server" ||
> entity_type == "table" ||
> entity_type == "tablet")
>
> This prevents enabling --metrics_prometheus_use_entity_labels=true for
> any entity type outside this set, including synthetic test entities
> (e.g. "test_entity"). As a result, unit tests for Prometheus filtering
> (KUDU-3690) cannot use the new label-based format and are forced to
> rely on the legacy format instead.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
