[
https://issues.apache.org/jira/browse/KUDU-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118830#comment-18118830
]
ASF subversion and git services commented on KUDU-3761:
-------------------------------------------------------
Commit ae52405967cd2709483ea5c02e613be50ab23f43 in kudu's branch
refs/heads/master from Gabriella Lotz
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=ae5240596 ]
KUDU-3761 drop default for prefer_follower_moves
LocationBalancingAlgo requires callers to pass
'prefer_follower_moves' explicitly. TwoDimensionalGreedyAlgo
still defaulted it to true, so callers could quietly opt into
follower-preferring behavior by leaving the arg off.
Drop that default. The trailing EqualSkewOption default goes
with it (defaults must be contiguous at the end); update the
zero/one-arg call sites in rebalance_algo-test.cc to pass both
args.
Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035
Reviewed-on: http://gerrit.cloudera.org:8080/24863
Reviewed-by: Ashwani Raina <[email protected]>
Reviewed-by: Marton Greber <[email protected]>
Tested-by: Marton Greber <[email protected]>
> Follower preference for LocationBalancingAlgo
> ---------------------------------------------
>
> Key: KUDU-3761
> URL: https://issues.apache.org/jira/browse/KUDU-3761
> Project: Kudu
> Issue Type: Sub-task
> Reporter: Gabriella Lotz
> Assignee: Gabriella Lotz
> Priority: Major
>
> Cross-location moves via {{LocationBalancingAlgo}} have zero follower
> awareness. Fixing this requires:
> 1. Passing {{ts_with_followers_by_table_and_tag}} into
> {{{}LocationBalancingAlgo::GetNextMove(){}}}{{{}, as currently it only
> receives LocationBalancingInfo{}}}
> 2. Applying the same two-candidate (non-leader vs fallback) pattern as
> {{TwoDimensionalGreedyAlgo}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
