[
https://issues.apache.org/jira/browse/KUDU-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18124206#comment-18124206
]
ASF subversion and git services commented on KUDU-3802:
-------------------------------------------------------
Commit 14b98e9b11e885edf0826c5fe84549ed1af683a1 in kudu's branch
refs/heads/master from Zoltan Martonka
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=14b98e9b1 ]
KUDU-3802 fix master-test build on old GCC
Bind the ASSERT_EVENTUALLY() lambda in ClusterLeaderSkewMetric to a
local instead of passing it inline. Older GCC (ubuntu18 toolchain)
resolves __LINE__ for tokens from a macro argument to the outer macro's
closing paren, so the two NO_FATALS() calls collided on the same gtest
goto label ("duplicate label 'gtest_label_testnofatal_917'"). Hoisting
the lambda out of the macro argument gives each NO_FATALS() its own line.
Change-Id: I18bc6154eb3831612ad33177d32f28cc846f4dbf
Reviewed-on: http://gerrit.cloudera.org:8080/25035
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
> Add cluster leader-skew gauge
> -----------------------------
>
> Key: KUDU-3802
> URL: https://issues.apache.org/jira/browse/KUDU-3802
> Project: Kudu
> Issue Type: Sub-task
> Reporter: Gabriella Lotz
> Assignee: Gabriella Lotz
> Priority: Major
>
> The counters on the auto-rebalancer and the ones added under KUDU-3791 for
> the auto-leader-rebalancer report activity: how many moves were scheduled,
> how many rounds completed. They don't report whether the cluster is currently
> skewed.
> The replica side already has this: cluster_replica_skew at ts_manager.cc:55
> is a function gauge that returns the difference between the tserver with the
> most replicas and the tserver with the fewest.
> Add a matching cluster_leader_skew gauge: max minus min leader count across
> live tservers. The leader rebalancer already computes this per-round in
> RunLeaderRebalancer, so the gauge can share that state or recompute on scrape.
> This gives operators a "does the cluster need rebalancing right now" signal
> to sit alongside the "is the rebalancer doing anything" signals from the
> counters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
