PragmaTwice commented on code in PR #584:
URL: https://github.com/apache/incubator-kvrocks/pull/584#discussion_r900886147
##########
cmake/rocksdb.cmake:
##########
@@ -38,10 +38,14 @@ FetchContent_GetProperties(snappy)
FetchContent_MakeAvailableWithArgs(rocksdb
CMAKE_MODULE_PATH=${PROJECT_SOURCE_DIR}/cmake/modules # to locate
FindJeMalloc.cmake
Snappy_DIR=${PROJECT_SOURCE_DIR}/cmake/modules # to locate SnappyConfig.cmake
+ lz4_ROOT_DIR=${LZ4_LIB_SOURCE_DIR}
+ lz4_LIBRARIES=${LZ4_LIB_SOURCE_DIR}/liblz4.a
+ lz4_INCLUDE_DIRS=${LZ4_LIB_SOURCE_DIR}
Review Comment:
Like cmake files in
[cmake/modules](https://github.com/apache/incubator-kvrocks/tree/unstable/cmake/modules),
injecting the lz4 target via hooking find package mechanism can propagate
dependency relation into the rocksdb target, in addition this makes the
dependencies more modular, we can easily do some switches to selectively enable
them.
Of course, if you are not familiar with them, I can follow up to help you
implement them : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
