PragmaTwice opened a new pull request, #643:
URL: https://github.com/apache/incubator-kvrocks/pull/643

   In kvrocks, `Status` is used to indicate the state of the operation when it 
is completed.
   
   Obviously, these operation will complete normally (often called a happy 
path) in most cases (or say, with high probability), and fail in a small number 
of cases.
   
   Field `msg_` typed `std::string` will be assigned to `ok` when constructing 
the normal state, which can be more time consuming than the default constructor 
(although usually `std::string` implementations in the standard library do SSO, 
small string optimization, thus heap allocation may be avoided).
   
   In this PR, I delayed the `ok` to message dumping to speed up the happy path.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to