tisonkun commented on code in PR #644:
URL: https://github.com/apache/incubator-kvrocks/pull/644#discussion_r902448104
##########
src/util.cc:
##########
@@ -371,7 +371,14 @@ std::string Trim(std::string in, const std::string &chars)
{
std::vector<std::string> Split(const std::string &in, const std::string
&delim) {
std::vector<std::string> out;
- if (in.empty() || delim.empty()) return out;
+ if (in.empty()) {
+ return out;
+ }
+
+ if (delim.empty()) {
Review Comment:
Yes. We don't have to follow other system's design, but we should make our
own utils semantic clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
