PragmaTwice commented on PR #649:
URL: 
https://github.com/apache/incubator-kvrocks/pull/649#issuecomment-1163289769

   > Could you describe a concrete use case that could benefits from this 
change? It seems we don't even configure `CMAKE_EXPORT_COMPILE_COMMANDS` for 
current cppcheck.
   
   Yeah, cppcheck allow user to not provide a `compile_commands.json`, but it 
will greatly affect the detection accuracy, and user need to provide all 
include dirs, standard, compile options manually to fix this.
   In static analysis and language server of C++, `compile_commands.json` is 
just a standard.
   Many C++ project like apache/doris, oneflow, clickhouse did something like 
this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to