git-hulk commented on PR #584: URL: https://github.com/apache/incubator-kvrocks/pull/584#issuecomment-1163886811
> @git-hulk thanks for your input. +1 to merge. > > BTW do you confirm that introduce lz4 support in this way won't cause dependency issue? IIRC lz4 can contain GPLv2 code, but if we use `lib` only, it should be fine. Yes that we use `lib` only, but NOT sure about whether we need to involve more people to discuss or not([previous discussion thread](https://lists.apache.org/thread/0krk4nwwvzv9hgc10h6f3owo00qccsxo)). I saw some apache projects also used the `LZ4` with downloading the repo: https://github.com/search?l=CMake&q=org%3Aapache+lz4%2Flz4&type=Code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
