PragmaTwice commented on code in PR #652:
URL: https://github.com/apache/incubator-kvrocks/pull/652#discussion_r905826626
##########
src/redis_request.cc:
##########
@@ -35,7 +35,7 @@
namespace Redis {
const size_t PROTO_INLINE_MAX_SIZE = 16 * 1024L;
const size_t PROTO_BULK_MAX_SIZE = 512 * 1024L * 1024L;
-const size_t PROTO_MULTI_MAX_SIZE = 1024 * 1024L;
+const int64_t PROTO_MULTI_MAX_SIZE = 1024 * 1024L;
Review Comment:
I also think it is better to keep `PROTO_MULTI_MAX_SIZE` typed `size_t`,
since semantically it is a positive number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
