wanghenshui commented on PR #764: URL: https://github.com/apache/incubator-kvrocks/pull/764#issuecomment-1206103067
> I mean how it affects kvrocks? When we add new features or improvements, we must know their earnings, for example, if this build option make kvrocks performance better, we should know that and how much it improves. Otherwise, other contributors may add new optimization options, we also don't know which option bring earnings or why, we will loss the control of this project, we also can't answer the users's question how to optimize the performance with build options. > > I don't say we will merge it only if this option must bring much obvious performance improvement, but we must know it clearly. In addition, not only for this PR changes, even if they are valid on another system, we also don't need to merge it if they don't bring earnings on kvrocks till now, since, for a long time, it will be more and more complex, and make it hard to maintain. > > BTW, if you merge this commit, also please describe it clearly in commit log. Do we have benchmark test? Or some scripts to test performence easy? We could use those stuff test LTO/before LTO difference. LTO is free lunch, just like change compiler from c++98 to c++11, c++17, more higher, more gains. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
