PragmaTwice commented on PR #764: URL: https://github.com/apache/incubator-kvrocks/pull/764#issuecomment-1206118943
Hi @ShooterIT, I agree with your argument that benchmark matters. I think we can wait for a benchmark before merge it or set `ENABLE_IPO` to OFF on default since LTO is practical in lots of database projects like [mysql](https://github.com/mysql/mysql-server/blob/8.0/CMakeLists.txt#L921), [clickhouse](https://github.com/ClickHouse/ClickHouse/blob/22.7/CMakeLists.txt#L399) and [mongodb](https://github.com/mongodb/mongo/blob/master/SConstruct#L217). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
