git-hulk commented on PR #768: URL: https://github.com/apache/incubator-kvrocks/pull/768#issuecomment-1212139529
> I wonder why kvrocks' Status uses std::string, it would be large, likely 24B on stack To be honest, we didn't think carefully about this case before, because AFAIK the bottleneck of Kvrocks is commonly at RocksDB or disk io latency. Of course, I think it will be good to optimize as much as possible if it can keep the code base simple at the same time. > Secondly, sometimes when we want to find the root cause of the problem, status make it hard to debug. apache doris thinks using exception is a better method: https://github.com/apache/doris/discussions/8406 I guess the reason why no one mentioned this issue: call the chain of Kvrocks is simple engouh: `command->data structure->rocksdb`, so we can tell the root cause even without exception stacks. Correct me if others don't agree with me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
