PragmaTwice commented on code in PR #793:
URL: https://github.com/apache/incubator-kvrocks/pull/793#discussion_r956746085
##########
src/redis_bitmap.cc:
##########
@@ -146,16 +146,27 @@ rocksdb::Status Bitmap::GetString(const Slice &user_key,
const uint32_t max_btos
// If you setbit bit 0 1, the value is stored as 0x01 in Kvrocks but 0x80
in Redis.
// So we need to swap bits is to keep the same return value as Redis.
+ static const uint8_t swap_table[256] = {
Review Comment:
Yeah, you can actually use templates.
For more details, you can refer to [this commit in
doris](https://github.com/apache/doris/commit/f49284036e1ed2bb5597cd6472720552a9c19054),
which has samiliar ideas.
The commit above is written in c++17, so some modification is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
