PragmaTwice commented on PR #797: URL: https://github.com/apache/incubator-kvrocks/pull/797#issuecomment-1232786155
> > Hi all, this PR is now ready for review! > > There is an error in TCL TLS test only in macOS, and I think I test a lot to ensure it works well in linux(centos or archlinux, openssl 1.0 or 1.1, tls v1 v1.1 v1.2 or v1.3). I will try to figure out the error in mac, and I will be very appreciated if you help me, since I have no Mac device. > > cc @git-hulk @ShooterIT @tisonkun @caipengbo > > Thanks @PragmaTwice, I will try to locate macOS issue, not sure whether it caused by macOS ssl configured to forbid the older version like 1.2 So thanks! The version of openssl in mac is probably 3.0, and you can check here to see the error: https://github.com/apache/incubator-kvrocks/runs/8110693005?check_suite_focus=true To reproduce the error, you can just follow `kvrocks.yml`: ``` git clone https://github.com/jsha/minica cd minica && go build && cd .. ./minica/minica --domains localhost mkdir -p tests/tcl/tests/tls cp localhost/cert.pem tests/tcl/tests/tls/server.crt cp localhost/key.pem tests/tcl/tests/tls/server.key cp localhost/cert.pem tests/tcl/tests/tls/client.crt cp localhost/key.pem tests/tcl/tests/tls/client.key cp minica.pem tests/tcl/tests/tls/ca.crt ./x.py test tcl build --tls --single unit/tls --single unit/command --dont-clean ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
