PragmaTwice commented on PR #803: URL: https://github.com/apache/incubator-kvrocks/pull/803#issuecomment-1233998316
> May you describe a bit how adding these two files helps resolve the issue? > > I think it's about CMake resolving order while it looks like we always set `GFLAGS_FOUND` & `GTEST_FOUND` to `false`. By default, for `find_package(X)`, CMake will use the builtin `FindX.cmake` file (provided by CMake) to find the X package. It will try to find the package in system, e.g. installed from package manager. We overwrite this file to make sure CMake do not use some builtin logic to find the package, because we do not need these package in snappy. It is actually a bug in (old version of) snappy, we defined `SNAPPY__BUILD_TEST=OFF`, but snappy will always find gtest regardless of our option, and we do not need gtest in snappy since we do not build unit tests in snappy. @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
