git-hulk commented on code in PR #808:
URL: https://github.com/apache/incubator-kvrocks/pull/808#discussion_r962111519


##########
src/redis_request.cc:
##########
@@ -61,13 +71,13 @@ Status Request::Tokenize(evbuffer *input) {
           } catch (std::exception &e) {
             return Status(Status::NotOK, "Protocol error: invalid multibulk 
length");
           }
+          if (isOnlyLF || multi_bulk_len_ > (int64_t)PROTO_MULTI_MAX_SIZE) {
+            return Status(Status::NotOK, "Protocol error: invalid multibulk 
length");
+          }

Review Comment:
   Redis also disallowed \n in multi bulk protocol, so we just keep consistent 
with Redis here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to