tanruixiang commented on issue #815: URL: https://github.com/apache/incubator-kvrocks/issues/815#issuecomment-1239665492
Hi. The comments in [incr.tcl](https://github.com/apache/incubator-kvrocks/blob/unstable/tests/tcl/tests/unit/type/incr.tcl#L133) indicate that these two cases cannot be tested. Should we also keep these two cases in the form of comments in go? ``` test {INCRBYFLOAT does not allow NaN or Infinity} { r set foo 0 set err {} catch {r incrbyfloat foo +inf} err set err # p.s. no way I can force NaN to test it from the API because # there is no way to increment / decrement by infinity nor to # perform divisions. } {ERR*would produce*} # TODO: INCRBYFLOAT precision for human friendly # test {INCRBYFLOAT decrement} { # r set foo 1 # roundFloat [r incrbyfloat foo -1.1] # } {-0.1} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
