PragmaTwice commented on PR #843: URL: https://github.com/apache/incubator-kvrocks/pull/843#issuecomment-1242611702
> LGTM. Tested on Apple M1. > > Out of curiosity, I notice that I don't set `CMAKE_OSX_DEPLOYMENT_TARGET` but instead `MACOSX_DEPLOYMENT_TARGET` and this patch doesn't cause fatal. But why? If `CMAKE_OSX_DEPLOYMENT_TARGET` is not set manually, it will be initialized by the environment variable `MACOSX_DEPLOYMENT_TARGET`. So it is consistent : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
