tanruixiang commented on code in PR #882: URL: https://github.com/apache/incubator-kvrocks/pull/882#discussion_r973593959
########## tests/cppunit/disk_test.cc: ########## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +#include <chrono> +#include <gtest/gtest.h> +#include <memory> +#include <vector> +#include <thread> +#include "redis_metadata.h" +#include "test_base.h" +#include "redis_string.h" +#include "redis_disk.h" +#include "redis_set.h" +#include "redis_list.h" +#include "redis_zset.h" +#include "redis_bitmap.h" +#include "redis_sortedint.h" + +class RedisDiskTest : public TestBase { +protected: + explicit RedisDiskTest() : TestBase() { + } + ~RedisDiskTest() = default; + +protected: +}; + +TEST_F(RedisDiskTest, StringDisk) { + key_ = "stringdisk_key"; + std::unique_ptr<Redis::String> string = Util::MakeUnique<Redis::String>(storage_, "disk_ns_string"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_string"); + std::vector<int> value_size{1, 1024}; + for(auto &p : value_size){ + EXPECT_TRUE(string->Set(key_, std::string(p, 'a')).ok()); + std::string got_value; + EXPECT_TRUE(string->Get(key_, &got_value).ok()); + EXPECT_EQ(got_value, std::string(p, 'a')); + std::string value; + string->Get(key_, &value); + uint64_t result = 0; + EXPECT_TRUE(disk->GetKeySize(key_, kRedisString, &result).ok()); + EXPECT_GE(result, p); + break; + } + string->Del(key_); +} + +TEST_F(RedisDiskTest, HashDisk) { + std::unique_ptr<Redis::Hash> hash = Util::MakeUnique<Redis::Hash>(storage_, "disk_ns_hash"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_hash"); + key_ = "hashdisk_key"; + fields_ = {"hashdisk_kkey1", "hashdisk_kkey2"}; + values_.resize(2); + std::vector<int>value_size{1, 1024}; + for(int i = 0 ;i < int(fields_.size()); i++){ + values_[i] = std::string(value_size[i],'a'); + } + int ret = 0; + uint64_t sum = 0; + for (int i = 0; i < int(fields_.size()); i++) { + sum += uint64_t(fields_[i].size()) + values_[i].size(); + rocksdb::Status s = hash->Set(key_, fields_[i], values_[i], &ret); + EXPECT_TRUE(s.ok() && ret == 1); + // waiting for data write + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + uint64_t key_size; + EXPECT_TRUE(disk->GetKeySize(key_, kRedisHash, &key_size).ok()); + EXPECT_GE(key_size, sum); + } + hash->Del(key_); +} + +TEST_F(RedisDiskTest, SetDisk) { + std::unique_ptr<Redis::Set> set = Util::MakeUnique<Redis::Set>(storage_, "disk_ns_set"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_set"); + key_ = "setdisk_key"; + values_.resize(2); + std::vector<int>value_size{1, 1024}; + for(int i = 0;i < int(values_.size()); i++){ + values_[i] = std::string(value_size[i],'a'); + } + + int ret = 0; + uint64_t sum = 0; + for (int i = 0; i < int(values_.size()); i++) { + std::vector<Slice>tmpv{values_[i]}; + sum += values_[i].size(); + rocksdb::Status s = set->Add(key_, tmpv, &ret); + EXPECT_TRUE(s.ok() && ret == 1); + // waiting for data write + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + uint64_t key_size; + EXPECT_TRUE(disk->GetKeySize(key_, kRedisSet, &key_size).ok()); + EXPECT_GE(key_size, sum); + } + set->Del(key_); +} + + +TEST_F(RedisDiskTest, ListDisk) { + std::unique_ptr<Redis::List> list = Util::MakeUnique<Redis::List>(storage_, "disk_ns_list"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_list"); + key_ = "listdisk_key"; + values_.resize(2); + std::vector<int>value_size{1,1024}; + for(int i = 0;i < int(values_.size()); i++){ + values_[i] = std::string(value_size[i],'a'); + } + int ret = 0; + uint64_t sum = 0; + for (int i = 0; i < int(values_.size()); i++) { + std::vector<Slice>tmpv{values_[i]}; + sum += values_[i].size(); + rocksdb::Status s = list->Push(key_, tmpv, false, &ret); + EXPECT_TRUE(s.ok() && ret == i + 1); + // waiting for data write + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + uint64_t key_size; + EXPECT_TRUE(disk->GetKeySize(key_, kRedisList, &key_size).ok()); + EXPECT_GE(key_size, sum); + } + list->Del(key_); +} + +TEST_F(RedisDiskTest, ZsetDisk) { + std::unique_ptr<Redis::ZSet> zset = Util::MakeUnique<Redis::ZSet>(storage_, "disk_ns_zet"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_zet"); + key_ = "zsetdisk_key"; + std::vector<MemberScore> mscores(2); + std::vector<int>value_size{1,1024}; + for(int i = 0;i < int(value_size.size()); i++){ + mscores[i].member = std::string(value_size[i],'a'); + mscores[i].score = 1.0 * value_size[int(values_.size()) - i - 1]; + } + int ret = 0; + uint64_t sum = 0; + for (int i = 0; i < int(mscores.size()); i++) { + std::vector<MemberScore> tmpv{mscores[i]}; + sum += 2 * mscores[i].member.size(); + rocksdb::Status s = zset->Add(key_, 0, &tmpv, &ret); + EXPECT_TRUE(s.ok() && ret == 1); + // waiting for data write + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + uint64_t key_size; + EXPECT_TRUE(disk->GetKeySize(key_, kRedisZSet, &key_size).ok()); + EXPECT_GE(key_size, sum); + } + zset->Del(key_); +} + +TEST_F(RedisDiskTest, BitmapDisk) { + std::unique_ptr<Redis::Bitmap> bitmap = Util::MakeUnique<Redis::Bitmap>(storage_, "disk_ns_bitmap"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_bitmap"); + key_ = "bitmapdisk_key"; + uint32_t offsets[] = {0, 123, 1024*8, 1024*8+1, 3*1024*8, 3*1024*8+1}; + + for (int i = 0; i < 6 ;i++) { + bool bit = false; + bitmap->GetBit(key_, offsets[i], &bit); + EXPECT_FALSE(bit); + bitmap->SetBit(key_, offsets[i], true, &bit); + bitmap->GetBit(key_, offsets[i], &bit); + EXPECT_TRUE(bit); + // waiting for data write + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + uint64_t key_size; + EXPECT_TRUE(disk->GetKeySize(key_, kRedisBitmap, &key_size).ok()); + EXPECT_GE(key_size, i + 1); + } + bitmap->Del(key_); +} + +TEST_F(RedisDiskTest, SortedintDisk) { + std::unique_ptr<Redis::Sortedint> sortedint = Util::MakeUnique<Redis::Sortedint>(storage_, "disk_ns_sortedint"); + std::unique_ptr<Redis::Disk> disk = Util::MakeUnique<Redis::Disk>(storage_, "disk_ns_sortedint"); + key_ = "sortedintdisk_key"; + int ret; + for(int i=0;i<10;i++){ Review Comment: I noticed that the running results of ci are somewhat different from those of my native machine. At the same time, because this is a draft pr, I am using ci for testing.I found that a byte of data is often not detected due to the problem with the settings of Writebatch(sync is default false). So don't worry. I'll fix it after the test. Thanks again for your serious review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
