git-hulk commented on PR #882: URL: https://github.com/apache/incubator-kvrocks/pull/882#issuecomment-1272282126
> > Sure, I have read through the implementation, and overall is good to me. I'm still wondering if we have a more general way to reduce duplicate codes, I will approve this PR soon if can't figure out a better way. > > Do you have any ideas? It seems like it should be impossible to reduce each type of custom operation. The main issue is `GetMetadata` requires to pass the type, so another way is to allow skipping type check in `GetMetadata`, but current implementation is also fine to me. To see others have thoughts on this cc @ShooterIT @PragmaTwice @caipengbo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
