PragmaTwice commented on issue #800: URL: https://github.com/apache/incubator-kvrocks/issues/800#issuecomment-1279169695
> By the way, I get the same result with clang14 which is the default version of macos. The latest clang is 15. If you can be sure that the result of 15 is the same, maybe there is no need to make judgments here. I think at least we can give a warning here and give the recommended clang version. Direct RuntimeError seems a bit inappropriate.@PragmaTwice https://github.com/apache/incubator-kvrocks/blob/unstable/x.py#L140 There are some difference (may not be encountered often) in format result between different version of clang-format. So I recommand developers use the same version of clang-format as in github actions. You can install a clang-format 12 or download from the URL provided in the message. I think it can be a warning, but developers may become angry when they format the code but still fail in the CI :rofl: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
