PragmaTwice commented on code in PR #1032:
URL:
https://github.com/apache/incubator-kvrocks/pull/1032#discussion_r1002849743
##########
tests/gocase/unit/type/strings/strings_test.go:
##########
@@ -605,12 +605,12 @@ func TestString(t *testing.T) {
})
t.Run("Extended SET with incorrect expire value", func(t *testing.T) {
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"0").Err(), "invalid expire time")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"exat", "1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"exat", "0").Err(), "invalid expire time")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"pxat", "1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"pxat", "0").Err(), "invalid expire time")
+ require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"1234xyz").Err(), "non-integer")
Review Comment:
I think it is hard to keep all error messages same as redis (and there are
currently lots of different error message between redis and kvrocks,
**including the two error message in your comment**), and it may make the
develop of kvrocks more and unnecessarily complex. And actually I think there
is nearly no difference between "syntax error" and "wrong number of arguments",
or "encounter non-integer characters" and "not a integer".
##########
tests/gocase/unit/type/strings/strings_test.go:
##########
@@ -605,12 +605,12 @@ func TestString(t *testing.T) {
})
t.Run("Extended SET with incorrect expire value", func(t *testing.T) {
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"0").Err(), "invalid expire time")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"exat", "1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"exat", "0").Err(), "invalid expire time")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"pxat", "1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"pxat", "0").Err(), "invalid expire time")
+ require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"1234xyz").Err(), "non-integer")
Review Comment:
I think it is hard to keep all error messages same as redis (and there are
currently lots of different error message between redis and kvrocks,
**including the two error message in your comments**), and it may make the
develop of kvrocks more and unnecessarily complex. And actually I think there
is nearly no difference between "syntax error" and "wrong number of arguments",
or "encounter non-integer characters" and "not a integer".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
