tisonkun commented on code in PR #1037:
URL:
https://github.com/apache/incubator-kvrocks/pull/1037#discussion_r1003310266
##########
src/main.cc:
##########
@@ -24,6 +24,9 @@
#include <stdlib.h>
Review Comment:
Perhaps remove `<getopt.h>` now.
##########
src/config/config.h:
##########
@@ -61,6 +61,14 @@ struct CompactionCheckerRange {
bool Enabled() { return Start != -1 || Stop != -1; }
};
+struct CLIOptions {
Review Comment:
nit: I'd prefer as simple as `Options`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
