PragmaTwice commented on code in PR #1048:
URL:
https://github.com/apache/incubator-kvrocks/pull/1048#discussion_r1008193358
##########
src/types/geohash.h:
##########
@@ -87,23 +87,23 @@ typedef enum {
GEOHASH_NORT_EAST
} GeoDirection;
-typedef struct {
+typedef struct GeoHashBits {
uint64_t bits = 0;
uint8_t step = 0;
} GeoHashBits;
Review Comment:
> We should need to add `struct` as the prefix when using it?
No. We are in C++, not C. : )
##########
src/types/geohash.h:
##########
@@ -87,23 +87,23 @@ typedef enum {
GEOHASH_NORT_EAST
} GeoDirection;
-typedef struct {
+typedef struct GeoHashBits {
uint64_t bits = 0;
uint8_t step = 0;
} GeoHashBits;
Review Comment:
> We should need to add `struct` as the prefix when using it?
No need. We are in C++, not C. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
