git-hulk commented on PR #1219: URL: https://github.com/apache/incubator-kvrocks/pull/1219#issuecomment-1375439771
> I have some comments on the file format. > > I think it is a new file format that relies on what is in the comments (starting with `#`) as part of the parsing, which is puzzling. I think we can try not to create a new file format as well as a new parsing logic. If this file is named `*.conf` (it is weird to have two different file format in one program that both have suffix `.conf`), I think we could better refer to the previous kvrocks conf file format, i.e. > > ``` > # a comment that does not affect parsing... > version 1 > id 0123456789012345678901234567890123456789 > node 07c37dfeb235213a872192d90877d0cd55635b91 127.0.0.1 63262 master - 0-2 4-8193 10000 10002-11002 16381-16383 > node ... > ``` > > And there are some util functions in `config/config_util.h` that can help parsing text in such file format. Yes, it'd be better to keep the same format, I will reconsider if it's other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
