git-hulk commented on code in PR #1219:
URL:
https://github.com/apache/incubator-kvrocks/pull/1219#discussion_r1064622391
##########
src/cluster/cluster.cc:
##########
@@ -487,8 +490,46 @@ Status Cluster::GetClusterNodes(std::string *nodes_str) {
}
std::string Cluster::GenNodesDescription() {
- // Generate slots info firstly
+ UpdateSlotsInfo();
+
+ std::string nodes_desc;
+ for (const auto &item : nodes_) {
+ const std::shared_ptr<ClusterNode> n = item.second;
+
+ std::string node_str;
+ // ID, host, port
+ node_str.append(n->id_ + " ");
+ node_str.append(fmt::format("{}:{}@{} ", n->host_, n->port_, n->port_ +
kClusterPortIncr));
+
+ // Flags
+ if (n->id_ == myid_) node_str.append("myself,");
+ if (n->role_ == kClusterMaster) {
+ node_str.append("master - ");
+ } else {
+ node_str.append("slave " + n->master_id_ + " ");
+ }
+
+ // Ping sent, pong received, config epoch, link status
Review Comment:
Good catch. This code is extracted from the previous implementation, it
should not get time every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
