git-hulk commented on code in PR #1215:
URL:
https://github.com/apache/incubator-kvrocks/pull/1215#discussion_r1068059260
##########
src/storage/storage.h:
##########
@@ -68,6 +68,7 @@ class Storage {
~Storage();
void SetWriteOptions(const Config::RocksDB::WriteOptions &config);
+ void FillSeekReadOptions(rocksdb::ReadOptions &read_options);
Review Comment:
I think we can rename `FillSeekReadOptions` => `SetReadOptions ` to keep
consistent with `SetWriteOptions`.
##########
src/config/config.cc:
##########
@@ -204,6 +204,8 @@ Config::Config() {
{"rocksdb.write_options.low_pri", true, new
YesNoField(&RocksDB.write_options.low_pri, false)},
{"rocksdb.write_options.memtable_insert_hint_per_batch", true,
new YesNoField(&RocksDB.write_options.memtable_insert_hint_per_batch,
false)},
+ /* rocksdb read options */
+ {"rocksdb.read_options.async_io", false, new
YesNoField(&RocksDB.read_options.async_io, true)},
Review Comment:
```suggestion
{"rocksdb.read_options.async_io", false, new
YesNoField(&RocksDB.read_options.async_io, true)},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
