PragmaTwice commented on code in PR #57:
URL:
https://github.com/apache/incubator-kvrocks-website/pull/57#discussion_r1111226945
##########
docusaurus.config.js:
##########
@@ -141,17 +145,17 @@ const config = {
],
},
],
- logo: {
- alt: 'Apache Incubator logo',
- src: 'img/apache-incubator.svg',
- href: 'https://incubator.apache.org/'
- },
- copyright: `<div style="text-align: left;">
- <div>
- <p style="font-family: Avenir-Medium,serif;font-size: 14px;color:
#999;line-height: 20px;"> Apache Kvrocks is an effort undergoing incubation at
The Apache Software Foundation (ASF), sponsored by the Apache Incubator.
Incubation is required of all newly accepted projects until a further review
indicates that the infrastructure, communications, and decision making process
have stabilized in a manner consistent with other successful ASF projects.
While incubation status is not necessarily a reflection of the completeness or
stability of the code, it does indicate that the project has yet to be fully
endorsed by the ASF. </p>
- </div>
- <div style="border-top: 1px solid #ccc;min-height: 60px;line-height:
20px;text-align: center;font-family: Avenir-Medium,serif;font-size: 14px;color:
#999;display: flex;align-items: center;"><span>Copyright © ${new
Date().getFullYear()} The Apache Software Foundation. Apache Kvrocks, Kvrocks,
and its feather logo are trademarks of The Apache Software
Foundation.</span></div>
- </div>`,
+ // logo: {
+ // alt: 'Apache Incubator logo',
+ // src: 'img/apache-incubator.svg',
+ // href: 'https://incubator.apache.org/'
+ // },
+ // copyright: `<div style="text-align: left;">
+ // <div>
+ // <p style="font-family: Avenir-Medium,serif;font-size:
14px;color: #999;line-height: 20px;"> Apache Kvrocks is an effort undergoing
incubation at The Apache Software Foundation (ASF), sponsored by the Apache
Incubator. Incubation is required of all newly accepted projects until a
further review indicates that the infrastructure, communications, and decision
making process have stabilized in a manner consistent with other successful ASF
projects. While incubation status is not necessarily a reflection of the
completeness or stability of the code, it does indicate that the project has
yet to be fully endorsed by the ASF. </p>
+ // </div>
+ // <div style="border-top: 1px solid #ccc;min-height:
60px;line-height: 20px;text-align: center;font-family:
Avenir-Medium,serif;font-size: 14px;color: #999;display: flex;align-items:
center;"><span>Copyright © ${new Date().getFullYear()} The Apache Software
Foundation. Apache Kvrocks, Kvrocks, and its feather logo are trademarks of The
Apache Software Foundation.</span></div>
+ // </div>`,
Review Comment:
As mentioned above, these need to be kept as the site belongs to ASF.
##########
src/css/custom.css:
##########
@@ -9,6 +9,11 @@
--ifm-color-primary: #3071a9;
--ifm-code-font-size: 95%;
--docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.1);
+ --ifm-footer-background-color:rgba(115, 150, 233, 0.61);
+ /* --ifm-footer-link-color:rgba(0, 0, 0, 1); */
+ /* --ifm-footer-link-font-family:'PingFang SC-Light';
+ --ifm-footer-link-font-size:28pt;
+ --ifm-footer-link-font-weight:light; */
Review Comment:
I think you have to make some note comments to explain why there are several
commented code line.
##########
src/pages/index.tsx:
##########
@@ -6,27 +6,42 @@ import Layout from '@theme/Layout';
import HomepageFeatures from '@site/src/components/HomepageFeatures';
import styles from './index.module.css';
+import Pic from '../../static/img/mainPic.png';
function HomepageHeader() {
const {siteConfig} = useDocusaurusContext();
return (
- <header className={clsx('hero hero--primary', styles.heroBanner)}>
- <div className="container">
- <h1 className="hero__title">{siteConfig.title}</h1>
- <p className="hero__subtitle">{siteConfig.tagline}</p>
- <div className={styles.buttons}>
+ <header className={clsx('hero hero--primary', styles.heroBanner)}
style={{backgroundImage:'linear-gradient(to top, rgba(230, 239, 255, 1) ,
rgba(255, 255, 255,
1))',textAlign:'left',fontWeight:'Semibold',fontFamily:'PingFang
SC-Semibold',display:'flex'}}>
+ <div className="container" style={{margin:'0 0 0 10%',width:'40%'}}>
+ <h1 className="hero__title"
style={{color:'black'}}>{siteConfig.title}</h1>
+ <h2 className='hero__secondary__title' style={{color:'rgba(40, 117,
243, 1)'}}>(incubating)</h2>
+ <div className="hero__subtitle" style={{color:'rgba(59, 61, 63,
1)',fontFamily:'PingFang
SC-Light',fontWeight:'Light',width:'30rem',marginTop:'2rem'}}>{siteConfig.tagline}</div>
Review Comment:
AFAIK PingFang FC is a proprietary font so maybe we cannot use it in our
site.
##########
src/css/custom.css:
##########
@@ -39,3 +44,16 @@
background: url("data:image/svg+xml,%3Csvg viewBox='0 0 24 24'
xmlns='http://www.w3.org/2000/svg'%3E%3Cpath fill='white' d='M12 .297c-6.63
0-12 5.373-12 12 0 5.303 3.438 9.8 8.205 11.385.6.113.82-.258.82-.577
0-.285-.01-1.04-.015-2.04-3.338.724-4.042-1.61-4.042-1.61C4.422 18.07 3.633
17.7 3.633 17.7c-1.087-.744.084-.729.084-.729 1.205.084 1.838 1.236 1.838 1.236
1.07 1.835 2.809 1.305
3.495.998.108-.776.417-1.305.76-1.605-2.665-.3-5.466-1.332-5.466-5.93
0-1.31.465-2.38 1.235-3.22-.135-.303-.54-1.523.105-3.176 0 0 1.005-.322 3.3
1.23.96-.267 1.98-.399 3-.405 1.02.006 2.04.138 3 .405 2.28-1.552 3.285-1.23
3.285-1.23.645 1.653.24 2.873.12 3.176.765.84 1.23 1.91 1.23 3.22 0 4.61-2.805
5.625-5.475 5.92.42.36.81 1.096.81 2.22 0 1.606-.015 2.896-.015 3.286 0
.315.21.69.825.57C20.565 22.092 24 17.592 24
12.297c0-6.627-5.373-12-12-12'/%3E%3C/svg%3E")
no-repeat;
}
+
+.header-slack-link:hover {
+ opacity: 0.6;
+}
+
+.header-slack-link::before {
+ content: '';
+ width: 24px;
+ height: 24px;
+ display: flex;
+ background:
url("data:image/svg+xml;charset=utf-8,%3Csvg%20viewBox%3D%220%200%2060%2060%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E%3Cpath%20d%3D%22m21.902.148c-3.299%200-5.973%202.68-5.973%205.985a5.979%205.979%200%200%200%205.973%205.985h5.974v-5.985a5.98%205.98%200%200%200%20-5.974-5.985m0%2015.96h-15.929c-3.299%200-5.973%202.68-5.973%205.986%200%203.305%202.674%205.985%205.973%205.985h15.93c3.298%200%205.973-2.68%205.973-5.985%200-3.306-2.675-5.986-5.974-5.986%22%20fill%3D%22%23097eff%22%3E%3C%2Fpath%3E%3Cpath%20d%3D%22m59.734%2022.094c0-3.306-2.675-5.986-5.974-5.986s-5.973%202.68-5.973%205.986v5.985h5.973a5.98%205.98%200%200%200%205.974-5.985m-15.929%200v-15.961a5.98%205.98%200%200%200%20-5.974-5.985c-3.299%200-5.973%202.68-5.973%205.985v15.96c0%203.307%202.674%205.987%205.973%205.987a5.98%205.98%200%200%200%205.974-5.985%22%20fill%3D%22%23097eff%22%3E%3C%2Fpath%3E%3Cpath%20d%3D%22m37.831%2060a5.98%205.98%200%200%200%205.974-5.985%205.98%205.98%200%200%200%20-5
.974-5.985h-5.973v5.985c0%203.305%202.674%205.985%205.973%205.985m0-15.96h15.93c3.298%200%205.973-2.68%205.973-5.986a5.98%205.98%200%200%200%20-5.974-5.985h-15.929c-3.299%200-5.973%202.68-5.973%205.985a5.979%205.979%200%200%200%205.973%205.985%22%20fill%3D%22%23ecb12f%22%3E%3C%2Fpath%3E%3Cpath%20d%3D%22m0%2038.054a5.979%205.979%200%200%200%205.973%205.985%205.98%205.98%200%200%200%205.974-5.985v-5.985h-5.974c-3.299%200-5.973%202.68-5.973%205.985m15.929%200v15.96c0%203.306%202.674%205.986%205.973%205.986a5.98%205.98%200%200%200%205.974-5.985v-15.961a5.979%205.979%200%200%200%20-5.974-5.985c-3.299%200-5.973%202.68-5.973%205.985%22%20fill%3D%22%23ecb12f%22%3E%3C%2Fpath%3E%3C%2Fsvg%3E")
Review Comment:
Is there a specific source for this background image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
