git-hulk commented on code in PR #1287:
URL:
https://github.com/apache/incubator-kvrocks/pull/1287#discussion_r1124081359
##########
src/cluster/slot_import.cc:
##########
@@ -27,9 +27,8 @@ SlotImport::SlotImport(Server *svr)
import_status_(kImportNone),
import_fd_(-1) {
std::lock_guard<std::mutex> guard(mutex_);
- // Let db_ and metadata_cf_handle_ be nullptr, then get them in real time
while use them.
+ // Let metadata_cf_handle_ be nullptr, then get them in real time while use
them.
// See comments in SlotMigrate::SlotMigrate for detailed reason.
- db_ = nullptr;
Review Comment:
No, it won't. It's right for the migration should always use the raw DB
instead of the wrapped one. Because we don't expect to read uncommitted writes
when migrating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
