tisonkun commented on PR #1343:
URL: 
https://github.com/apache/incubator-kvrocks/pull/1343#issuecomment-1478896708

   > We may need to document this in the docs
   
   You're welcome to add a section or new page in 
https://kvrocks.apache.org/community/contributing/, following 
https://pingcap.github.io/tidb-dev-guide/get-started/write-and-run-unit-tests.html
 or other practice.
   
   > will it be cleaned up
   
   That's by design. As @PragmaTwice mentioned, when tests failed, you'd 
generally when to find the cause, right?
   
   The technical reason is that we register the cleanup func in `defer` which 
is only called on `runtime.exit`, not fatal (which is the case on `require.xxx` 
fails.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to