torwig commented on issue #1350: URL: https://github.com/apache/incubator-kvrocks/issues/1350#issuecomment-1484141375
I respect the reasoning about introducing a separate command for a blocking version of the command: it's clearer, descriptive and consistent with some naming conventions of Redis (e. g. POP/BPOP). On the other hand, if I use the blocking version of the MIGRATE command by specifying the proper options, it's obvious (at least for me) that it **will block** and the OK return value means "blocking operation is completed" (in other words, migration completed). And one quick note: personally, I don't like commands with a bunch of options (three and more). They are harder to implement and test. So, maybe _sometimes_ (but I'm not 100% sure that this case is the one), instead of introducing 2-3 additional options, we can create a new command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
