git-hulk commented on code in PR #1373:
URL:
https://github.com/apache/incubator-kvrocks/pull/1373#discussion_r1160380011
##########
src/cluster/slot_migrate.h:
##########
@@ -133,52 +123,51 @@ class SlotMigrate : public Redis::Database {
Status MigrateStream(const rocksdb::Slice &key, const StreamMetadata
&metadata, std::string *restore_cmds);
Status MigrateBitmapKey(const InternalKey &inkey,
std::unique_ptr<rocksdb::Iterator> *iter,
std::vector<std::string> *user_cmd, std::string
*restore_cmds);
+
Status SendCmdsPipelineIfNeed(std::string *commands, bool need);
void ApplyMigrationSpeedLimit() const;
Status GenerateCmdsFromBatch(rocksdb::BatchResult *batch, std::string
*commands);
Status MigrateIncrementData(std::unique_ptr<rocksdb::TransactionLogIterator>
*iter, uint64_t end_seq);
- Status SyncWalBeforeForbidSlot();
- Status SyncWalAfterForbidSlot();
+ Status SyncWalBeforeForbiddingSlot();
Review Comment:
Should we also change `Wal` to `WAL` for keeping consistent with previous
function `SyncWAL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
