PragmaTwice commented on code in PR #1374: URL: https://github.com/apache/incubator-kvrocks/pull/1374#discussion_r1161380374
########## kvrocks.conf: ########## @@ -587,15 +587,23 @@ rocksdb.target_file_size_base 128 # allowed. rocksdb.max_write_buffer_number 4 +# Maximum number of concurrent background jobs (compactions and flushes). +# RocksDB automatically decides this based on the value of max_background_jobs.# For backwards compatibility we will set `max_background_jobs = +# max_background_compactions + max_background_flushes` in the case where user +# sets at least one of `max_background_compactions` or `max_background_flushes` # (we replace -1 by 1 in case one option is unset). + rocksdb.max_background_jobs 4 + +# DEPRECATED : RocksDB automatically decides this based on the value of max_background_jobs Review Comment: ```suggestion # DEPRECATED: it is automatically decided based on the value of rocksdb.max_background_jobs ``` ########## kvrocks.conf: ########## @@ -587,15 +587,23 @@ rocksdb.target_file_size_base 128 # allowed. rocksdb.max_write_buffer_number 4 +# Maximum number of concurrent background jobs (compactions and flushes). +# RocksDB automatically decides this based on the value of max_background_jobs.# For backwards compatibility we will set `max_background_jobs = +# max_background_compactions + max_background_flushes` in the case where user +# sets at least one of `max_background_compactions` or `max_background_flushes` # (we replace -1 by 1 in case one option is unset). + rocksdb.max_background_jobs 4 + +# DEPRECATED : RocksDB automatically decides this based on the value of max_background_jobs # Maximum number of concurrent background compaction jobs, submitted to # the default LOW priority thread pool. -rocksdb.max_background_compactions 4 +rocksdb.max_background_compactions -1 +# DEPRECATED : RocksDB automatically decides this based on the value of max_background_jobs Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
