PragmaTwice commented on code in PR #1374: URL: https://github.com/apache/incubator-kvrocks/pull/1374#discussion_r1164246228
########## kvrocks.conf: ########## @@ -588,17 +588,19 @@ rocksdb.target_file_size_base 128 rocksdb.max_write_buffer_number 4 # Maximum number of concurrent background jobs (compactions and flushes). -# RocksDB automatically decides this based on the value of max_background_jobs.# For backwards compatibility we will set `max_background_jobs = -# max_background_compactions + max_background_flushes` in the case where user -# sets at least one of `max_background_compactions` or `max_background_flushes` # (we replace -1 by 1 in case one option is unset). +# RocksDB automatically decides this based on the value of max_background_jobs. Review Comment: This line does not make sense. `rocksdb.max_background_jobs` cannot be decided by its own. Please be careful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
