git-hulk opened a new pull request, #1384: URL: https://github.com/apache/incubator-kvrocks/pull/1384
we supported loading the cluster nodes from the local file, but we just ignored the cluster node id after parsing. So it can't match the cluster node since the local node id is empty, and it will fall back to check if the listening IP and port are matched. For example, we create a cluster with a single node and listen on 0.0.0.0, then we would get the below output after restarting: ```shell $ 127.0.0.1:6666> cluster nodes 3dQzcqeiTpSqPstxtD1utGuU52fPkGnoIHPO8KgL 127.0.0.1:6666@16666 master - 1681396166414 1681396166415 0 connected 0-16383 ``` it missed a `myself` field because didn't use the node id from the local file, then it will fall back to IP/Port, but the listening IP 0.0.0.0 is unmatched with 127.0.0.1, this issue was submitted in #1381. After this PR, we can get the correct result: ```shell $ 127.0.0.1:6666> cluster nodes 3dQzcqeiTpSqPstxtD1utGuU52fPkGnoIHPO8KgL 127.0.0.1:6666@16666 myself,master - 1681396232426 1681396232427 0 connected 0-16383 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
