rueian opened a new issue, #1403:
URL: https://github.com/apache/incubator-kvrocks/issues/1403

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-kvrocks/issues) and found no 
similar issues.
   
   
   ### Version
   
   2.3.0
   
   ### Minimal reproduce step
   
   1. Set `requirepass mypass`
   2. Send command: `HELLO 2 AUTH default mypass` after connected.
   
   
   ### What did you expect to see?
   
   mypass should be accepted.
   
   ### What did you see instead?
   
   `invalid password` error.
   
   ### Anything Else?
   
   Hi, 
   
   According to https://redis.io/commands/hello, the syntax of `HELLO` should 
be 
   ```
   HELLO [protover [AUTH username password] [SETNAME clientname]]
   ```
   and the default username should be `default`.
   
   However, kvrocks' syntax seems to lack the username part:
   
https://github.com/apache/incubator-kvrocks/blob/6889b5916ab560ecd5eed79bb9786e36342f0e17/src/commands/cmd_server.cc#L660
   
   Not sure if this is intended? But I think it will be great if matching 
redis' syntax.
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to