PragmaTwice commented on code in PR #1414:
URL:
https://github.com/apache/incubator-kvrocks/pull/1414#discussion_r1182196304
##########
CMakeLists.txt:
##########
@@ -164,6 +166,12 @@ if ((PROJECT_VERSION STREQUAL "unstable") AND (GIT_SHA
STREQUAL ""))
endif ()
configure_file(src/version.h.in ${PROJECT_BINARY_DIR}/version.h)
+if (NOT CMAKE_BUILD_TYPE OR CMAKE_BUILD_TYPE STREQUAL "None")
+ set (CMAKE_BUILD_TYPE "RelWithDebInfo")
+ message (STATUS "CMAKE_BUILD_TYPE is not set, set to default =
${CMAKE_BUILD_TYPE}")
+endif ()
+message (STATUS "CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
Review Comment:
IIRC `x.py` already has a default build type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
