PragmaTwice commented on code in PR #1415:
URL:
https://github.com/apache/incubator-kvrocks/pull/1415#discussion_r1182558899
##########
Dockerfile:
##########
@@ -37,6 +37,10 @@ WORKDIR /kvrocks
COPY --from=build /kvrocks/build/kvrocks ./bin/
+ARG TARGETARCH
+COPY tools/redis-cli-${TARGETARCH} /usr/bin/redis-cli
+RUN chmod a+x /usr/bin/redis-cli
Review Comment:
I think these conditional branches related to arch in the current changes is
not necessary. You can just build redis-cli in the dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
